topo: allow marshalling RWTopology #3746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
requested review from
lukedirtwalker and
scrye
and removed request for
lukedirtwalker
scrye
approved these changes
May 6, 2020
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Change the `Attributes` field type to []trc.Attribute in order to allow marshalling the RWTopology for non-primary ASes. fixes scionproto#3745
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
Attributesfield type to []trc.Attribute in order toallow marshalling the RWTopology for non-primary ASes.
fixes #3745
With the X509 style certificates, the
trcpackage will eventually be removed, and we need to revisit this to have a clean solution.This change is