Remove dead code related to segment requests #3748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzf
changed the title
lukedirtwalker
approved these changes
May 12, 2020
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
a discussion (no related file):
I'm surprised we never used it 🙈 but you're right this will change anyway so let's remove it now.
This segment request validation appears to never have been activated. This will be solved differently in the future, by having a separate segment request handler for local requests (TCP only) and, in core ASes only, a simpler handler for requests from other path servers (over SCION/QUIC). This will simplify the validation of the requests, so the existing code would not help a lot.
These have become unused by removing the request holding feature in scionproto#3604.
matzf
force-pushed
the
segfetcher-rm-validator
branch
from
9745548 to
0b0f539
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code for segment request validation
This segment request validation appears to never have been activated.
This will be solved differently in the future, by having a separate segment request handler for local requests (TCP only) and, in core ASes only, a simpler handler for requests from other path servers (over SCION/QUIC). This will simplify the validation of the requests, so the existing code would not help a lot.
Remove unused
RetrySleepandIsParamsLocalfrom segreq. These have become unused by removing the request holding feature in PS: Remove request holding #3604.Replace use of now unneeded
segreq.LocalInfointerface withsegfetcher.LocalInfoThis change is