Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colibri: application level types requests #3763

Merged

Conversation

juagargi
Copy link
Contributor

@juagargi juagargi commented May 12, 2020

Add functions to convert between application level types and control messages from Capnp.


This change is Reviewable

@juagargi juagargi force-pushed the colibri.application_level_types_requests branch from 55322f7 to d5f92d6 Compare May 12, 2020 12:17
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@juagargi juagargi force-pushed the colibri.application_level_types_requests branch from d5f92d6 to 35eda4d Compare May 13, 2020 12:53
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla changed the title Colibri.application level types requests colibri: application level types requests May 13, 2020
@oncilla oncilla merged commit 8ede270 into scionproto:master May 13, 2020
@juagargi juagargi deleted the colibri.application_level_types_requests branch May 13, 2020 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants