Remove obsolete limit on path segments in SegReply #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An arbitrary limit to 9 path segments in a SegReply was implemented some time ago as a hack to avoid exceeding MTU. This is no longer necessary as QUIC is now used as transport for these path segment requests.
|
Note: I noticed this while working on the implementation of #3731; in this context, the code modified here will be removed anyway, but it seemed to make sense to clean this up independently. |
lukedirtwalker
approved these changes
May 13, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
matzf
added a commit
to matzf/scion
that referenced
this pull request
May 25, 2020
An arbitrary limit to 9 path segments in a SegReply was implemented some time ago as a hack to avoid exceeding MTU. This is no longer necessary as QUIC is now used as transport for these path segment requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An arbitrary limit to 9 path segments in a SegReply was implemented some time ago as a hack to avoid exceeding MTU. This is no longer necessary as QUIC is now used as transport for these path segment requests.
This change is