combinator: enable header v2 path combination #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add combinator logic that is capable of handling v2 segments. The combinator decides whether a segment is v1 or v2 based on the value in the ISD field of the control plane segment. In v1, this field is always non-zero, in header v2 this is always zero. The SCION Daemon API is extended such that it attaches the header version to the replies. Client logic then decides whether to initialize the path as header v1 or header v2 path.
oncilla
commented
Jun 30, 2020
There was a problem hiding this comment.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add combinator logic that is capable of handling v2 segments.
The combinator decides whether a segment is v1 or v2 based on the
value in the ISD field of the control plane segment. In v1, this
field is always non-zero, in header v2 this is always zero.
The SCION Daemon API is extended such that it attaches the header version
to the replies. Client logic then decides whether to initialize the
path as header v1 or header v2 path.
This change is