cs: purge global state #3827
Merged
cs: purge global state #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
commented
Jul 10, 2020
There was a problem hiding this comment.
Reviewed 5 of 6 files at r1, 28 of 28 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
/rebase |
Purge the global state from the control server.
Drop the hook system work around.
As part of this pull request, the control server is moved to cobra.
The flags slightly changed compared to the previous implementation.
With the move to cobra, the flags are POSIX style, and no longer go style.
This means `-config` is no longer a valid flag. Instead, use:
cs --config cs.toml
The sample file generation has been moved to a sub command:
cs sample config
cs sample policy
Auto completion support is added as a sub command:
cs completion --help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purge the global state from the control server.
Drop the hook system work around.
As part of this pull request, the control server is moved to cobra.
The flags slightly changed compared to the previous implementation.
With the move to cobra, the flags are POSIX style, and no longer go style.
This means
-configis no longer a valid flag. Instead, use:The sample file generation has been moved to a sub command:
Auto completion support is added as a sub command:
This change is