segfetcher: do recursive request in parallel #3836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The destination provider might itself fetch segments and thus might take quite some time. We should not let the first request block other requests. Therefore execute the dst provider also in the request go routine. This should improve stability of the new path lookup. Also create separate spans for each request so that it becomes easier to debug what is going on.
oncilla
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
oncilla
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The destination provider might itself fetch segments and thus might take
quite some time. We should not let the first request block other
requests. Therefore execute the dst provider also in the request go
routine.
This should improve stability of the new path lookup.
Also create separate spans for each request so that it becomes easier to
debug what is going on.
This change is