colibri: advance request handling

[juagargi]

• Segment request operations are complete
• E2E request operations with the exception of the admission one are complete

---

This change is 

[oncilla]

Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @juagargi)

---

go/cs/reservationstore/store.go, line 149 at r1 (raw file):

		return nil, serrors.WrapStr("error validating request", err, "id", req.ID)
	}
	response, err := s.prepareFailureSegmentResp(&req.Request)

more of a style comment, so feel free to ignore, since it is really subjective.

I would introduce a new line before this line, and one before s.db.BeginTransaction to group according to logical coherence.

---

go/cs/reservationstore/store.go, line 180 at r1 (raw file):

			"id", req.ID)
	}
	var msg base.MessageWithPath

Just do:

	if req.IsLastAS() {
		return &segment.ResponseIndexConfirmationSuccess{
			Response: *morphSegmentResponseToSuccess(response),
		}, nil
	}
	return req, nil

same comment for all other methods where this applies.

[juagargi]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/cs/reservationstore/store.go, line 149 at r1 (raw file):

Previously, Oncilla (Dominik Roos) wrote…

more of a style comment, so feel free to ignore, since it is really subjective.

I would introduce a new line before this line, and one before s.db.BeginTransaction to group according to logical coherence.

Done.

---

go/cs/reservationstore/store.go, line 180 at r1 (raw file):

Previously, Oncilla (Dominik Roos) wrote…

Just do:

	if req.IsLastAS() {
		return &segment.ResponseIndexConfirmationSuccess{
			Response: *morphSegmentResponseToSuccess(response),
		}, nil
	}
	return req, nil

same comment for all other methods where this applies.

Done.

[oncilla]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @juagargi and @oncilla)

---

go/cs/reservationstore/store.go, line 149 at r1 (raw file):

Previously, juagargi (Juan A. Garcia Pardo) wrote…

Done.

It applies to the other methods as well :)

---

go/cs/reservationstore/store.go, line 180 at r1 (raw file):

Previously, juagargi (Juan A. Garcia Pardo) wrote…

Done.

As mentioned, this applies to the other methods as well

[juagargi]

Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @oncilla)

---

go/cs/reservationstore/store.go, line 149 at r1 (raw file):

Previously, Oncilla (Dominik Roos) wrote…

It applies to the other methods as well :)

Done. Done. Too much in a hurry 😛

---

go/cs/reservationstore/store.go, line 180 at r1 (raw file):

Previously, Oncilla (Dominik Roos) wrote…

As mentioned, this applies to the other methods as well

Done.

[oncilla]

Reviewed 1 of 1 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved

[oncilla]

Reviewable status: complete! all files reviewed, all discussions resolved

[juagargi]

/rebase

[juagargi]

/rebase