snet: PathInterface struct #3879
Conversation
matzf
force-pushed
the
snet-pathinterface-struct
branch
from
e653717 to
80aec0e
Compare
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
go/cs/segutil/router.go, line 105 at r1 (raw file):
} type path struct {
AFAIU, there is no longer a need for this struct.
Can you maybe elaborate a bit on the plan for this and future PRs?
I assume this is some preparation PR, and then there will be a follow-up that cleans up the uneccessary structs.
Is that correct?
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/cs/segutil/router.go, line 105 at r1 (raw file):
I assume this is some preparation PR, and then there will be a follow-up that cleans up the uneccessary structs.
Yup.
In the current state, this is implementation of the Path interface is still used/needed. This PR only removes the PathInterface interface type.
The next step will be to combine the sciond and segutil implementations of path, i.e. the main part of #3872. This is when I will remove this type here.
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
|
/rebase |
Use a simple struct directly instead of an interface. Contrary to what was implied by code comments, this does not appear to introduce any problematic dependencies.
github-actions
bot
force-pushed
the
snet-pathinterface-struct
branch
from
80aec0e to
b1f6e98
Compare
Make `snet.PathMetadata` a struct instead of an interface. Analogous to how this was done for `snet.PathInterface` (#3879). The indirection with an interface is simply unnecessary. Making this a struct, will allow to extend the `PathMetadata` struct quite easily: in a next PR, we'll add the latency, bandwidth, geo coordinates etc. from the "static info" beaconing extension (currently, these fields are defined in a shadow copy of `PathMetadata` in `combinator/staticinfo_accumulator.go`). Move `Interfaces` to `snet.PathMetadata`. The `Interfaces` list is available exactly if the other metadata items are available, so it makes sense to bundle these. This requires/brings some changes to `pathpol.PathSet` -- now the pathpol is fed directly with the `snet.PathMetadata` struct. This seems quite natural, as it's conceivable that the path policy would access all the various metadata items in the future. This change also requires some minor adjustments at the call sites for the path policies.
Use a simple struct for
snet.PathInterfacedirectly instead of an interface.Contrary to what was implied by code comments, this does not appear to
introduce any problematic dependencies.
Contributes to #3872
This change is