cleanup: drop lib/assert, lib/addr.AppAddr, lib/l4 #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebase |
Use in new code has been discouraged and the asserts have not not been enabled for the (bazel) builds anyway. Keep some of the checks with explicit panic for places that are clearly not on the hot path
github-actions
bot
force-pushed
the
purge-misc
branch
from
14e6441 to
08429c4
Compare
lukedirtwalker
approved these changes
Oct 30, 2020
There was a problem hiding this comment.
Reviewed 26 of 26 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
a discussion (no related file):
thanks for cleaning this up 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
drop lib/assert
Use in new code has been discouraged and the asserts have not not been
enabled for the (bazel) builds anyway.
Keep some of the checks with explicit panic for places that are clearly
not on the hot path
drop lib/addr.AppAddr
drop lib/l4
This change is