snet/sciond: add static info metadata fields to snet.PathMetadata #3924
Conversation
matzf
force-pushed
the
snet-path-metadata-staticinfo
branch
from
4a4cf63 to
37a2050
Compare
matzf
force-pushed
the
snet-path-metadata-staticinfo
branch
from
37a2050 to
dcb5e8e
Compare
There was a problem hiding this comment.
Reviewed 10 of 11 files at r1.
Reviewable status: 10 of 11 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker and @matzf)
go/lib/snet/path.go, line 70 at r1 (raw file):
these entries are signed is signed
I think the is signed needs to be dropped. Also this comment doesn't really hold true for the existing information, for example MTU can't be attributed to each AS, since it's a result of a calculation. I think it would be nice to clarify this in some way.
go/lib/snet/path.go, line 134 at r1 (raw file):
type LinkType uint8 const (
add a comment to this block. // LinkType values
go/lib/snet/path.go, line 141 at r1 (raw file):
) type GeoCoordinates struct {
Add a comment.
There was a problem hiding this comment.
Reviewed 1 of 11 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @matzf)
There was a problem hiding this comment.
Reviewable status: 10 of 11 files reviewed, 3 unresolved discussions (waiting on @lukedirtwalker)
go/lib/snet/path.go, line 70 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
these entries are signed is signedI think the
is signedneeds to be dropped. Also this comment doesn't really hold true for the existing information, for example MTU can't be attributed to each AS, since it's a result of a calculation. I think it would be nice to clarify this in some way.
You're right, not really clear what it was trying to say. Rephrased it, better?
go/lib/snet/path.go, line 134 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
add a comment to this block.
// LinkType values
Done.
go/lib/snet/path.go, line 141 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Add a comment.
Done.
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
|
/rebase |
Add static info metadata fields, from their temporary location in the path combinator to snet.PathMetadata. Add to sciond protobuf protocol definitions to transport this information along with sciond path replies.
github-actions
bot
force-pushed
the
snet-path-metadata-staticinfo
branch
from
8b1308b to
79e5644
Compare
Add static info metadata fields, from their temporary location in the path combinator to
snet.PathMetadata. Add these fields to the sciond protobuf protocol definitions to transport this information along with sciond path replies.This change is