dispatcher: fix panic on read error #3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Reviewable status:
a discussion (no related file):
good catch, thanks 💯
|
/rebase |
Fix nil pointer dereference panic in error case of Read from unconnected underlay conn. This is only a minor edge case; the problem only occured on read errors which the dispatcher considers fatal anyway. However, the panic did mask the cause for the read error (in my case, too many open files) from the logs. Note that the router uses connected underay conns, which use a different code path.
github-actions
bot
force-pushed
the
fix-panic-underlayconn-read
branch
from
8da1f1a to
b255b40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix nil pointer dereference panic in error case of Read from unconnected
underlay conn.
This is only a minor edge case; the problem only occured on read errors
which the dispatcher considers fatal anyway. However, the panic did
mask the cause for the read error (in my case, too many open files) from
the logs.
Note that the router uses connected underay conns, which use a different
code path.
This change is