Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmds: usage string based on binary name #3937

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

matzf
Copy link
Contributor

@matzf matzf commented Nov 24, 2020

Renaming binaries is sometimes preferrable or even necessary when
creating distribution packages. In order to reduce confusion for the
users, it's nice when the built in help text of the applications refers
to the actually used name of the binary.

By adapting the Use string, cobra also generates correct completion
scripts when using a changed name for the binary.


This change is Reviewable

Renaming binaries is sometimes preferrable or even necessary when
creating distribution packages. In order to reduce confusion for the
users, it's nice when the built in help text of the applications refers
to the actually used name of the binary.

By adapting the `Use` string, cobra also generates correct completion
scripts when using a changed name for the binary.
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: 💯

Reviewed 8 of 8 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla
Copy link
Contributor

oncilla commented Nov 25, 2020

/rebase

@oncilla oncilla merged commit 6abe062 into scionproto:master Nov 26, 2020
@matzf matzf deleted the cobra-use branch April 23, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants