acceptance: bazelify trc ceremony tests #4209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matzf
force-pushed
the
bazelify-trc-ceremony-test
branch
11 times, most recently
from
69c1949 to
68f5d43
Compare
matzf
force-pushed
the
bazelify-trc-ceremony-test
branch
from
68f5d43 to
4e0919d
Compare
oncilla
approved these changes
Jun 7, 2022
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matzf)
.bazelrc line 26 at r1 (raw file):
test:integration --test_tag_filters=integration,-lint test:integration_go --config=integration -- //... -//acceptance/... -//demo/...
Suggestion:
test:integration_go --config=integration -- //... -//acceptance/... -//demo/... -//tools/cryptoplayground/...
matzf
force-pushed
the
bazelify-trc-ceremony-test
branch
from
4e0919d to
6d493e2
Compare
matzf
commented
Jun 7, 2022
There was a problem hiding this comment.
Reviewable status: 5 of 6 files reviewed, 1 unresolved discussion (waiting on @oncilla)
.bazelrc line 26 at r1 (raw file):
test:integration --test_tag_filters=integration,-lint test:integration_go --config=integration -- //... -//acceptance/... -//demo/...
Done.
oncilla
approved these changes
Jun 8, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @matzf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazelify TRC ceremony tests.
The motivation/goal is that developers can run all integration tests locally with a single command.
Change invocation of test in CI to explicitly run these tests with bazel; this will be streamlined by combining this with the acceptance test steps in a follow up PR.
This change is