Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade to Go 1.18.5 #4248

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Aug 26, 2022

Also upgrade:

  • rules_go to v0.34
  • gazelle to v0.26
  • quic-go to v0.27.2

Also drop the dependency on the custom gomock bazel library, instead use
the rules_go gomock rule.


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from matzf August 26, 2022 06:26
Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

CI fails only because the protobuf files need to be regenerated (header changed) and some line numbers for the stacktrace in the in the serrors test golden files have changed (golden file just needs to be updated).

Reviewed 56 of 56 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker)


go_deps.bzl line 997 at r1 (raw file):

    go_repository(
        name = "com_github_marten_seemann_qtls_go1_18",
        build_directives = ["gazelle:exclude generate_cert.go"],  # XXX(matzf): this file has a "// go:build ignore" instruction that gazelle does not understand

This should no longer be necessary with the patched gazelle. 🎉


patches/README.md line 6 at r1 (raw file):

that simplify the migration when breaking changes to library packages are
introduced. Furthermore it contains patches to dependencies in subdirectories,
the remainder of this document is only about the patches for migrations. 

Trailing whitespace (lint error)

@lukedirtwalker lukedirtwalker self-assigned this Aug 30, 2022
Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Reviewable status: 54 of 76 files reviewed, 2 unresolved discussions (waiting on @lukedirtwalker and @matzf)


go_deps.bzl line 997 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

This should no longer be necessary with the patched gazelle. 🎉

Done.

Code quote:

com_github_marten_seemann_qtls_go1_18

patches/README.md line 6 at r1 (raw file):

Previously, matzf (Matthias Frei) wrote…

Trailing whitespace (lint error)

Done.

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh there also seem to be some new "nogo" errors in external libraries that now need to be excluded.

Reviewed 22 of 22 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukedirtwalker)

Also upgrade:
- rules_go to v0.34
- gazelle to v0.26
- quic-go to v0.27.2

Also drop the dependency on the custom gomock bazel library, instead use
the rules_go gomock rule.
Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now. There was a failing e2e test, which I assume was a flake.

Reviewable status: 76 of 81 files reviewed, all discussions resolved (waiting on @lukedirtwalker)

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @lukedirtwalker)

@lukedirtwalker lukedirtwalker merged commit 8366106 into scionproto:master Aug 30, 2022
@lukedirtwalker lukedirtwalker deleted the goUpgrade branch August 30, 2022 11:06
benthor pushed a commit to benthor/scion that referenced this pull request Nov 24, 2022
Also upgrade:
- rules_go to v0.34
- gazelle to v0.26
- quic-go to v0.27.2

Also drop the dependency on the custom gomock bazel library, instead use
the rules_go gomock rule.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants