-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python: update pyyaml to 6.0.0 #4367
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @uniquefine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @uniquefine)
Note: while the update pyyaml was the right thing to fix the failing builds, the
This is related to the recent Cython 3.0.0 release, which is silently picked up during the build of the pyyaml wheel. See the sort of related discussion in yaml/pyyaml#702 (perhaps we should have picked 6.0.1). This highlights that some internal dependencies are not pinned (which is bad). I currently don't know if this is a mistake on our side, or with rules_python, or somewhere deep in the python wheel-house. |
Update pyyaml dependency from 6.0.0 -> 6.0.1, as amendment to #4367. The actual issue that had caused our builds to fail suddenly, was not related to the license_file warning, but an AttributeError related to a "cython_sources" option. It appears that pyyaml had an unconstrained version of for Cython as a build system dependency. When Cython 3 was released, this started to fail. Pyyaml 6.0.1 now has a constraint for Cython version < 3, which should keep things working. Somewhat worrying, and not addressed by this change, is the fact that the build system dependencies do not seem to be pinned by our requirements.txt file.
Update the pyyaml dependency to 6.0.0.
6.0.0 includes this commit that removes the use of the deprecated
license_file
field in the setup.cfg.This addresses the following warning:
This change is