acceptance: de-flake cert_renewal and hidden_paths #4399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiceatscion
approved these changes
Sep 28, 2023
Use the existing await-connectivity script to determine when a test can safely start to run, instead of sleeping for arbitrary number of seconds.
matzf
force-pushed
the
fix-flake-cert-renewal
branch
from
cec9ae5 to
2816daa
Compare
jiceatscion
pushed a commit
to jiceatscion/scion
that referenced
this pull request
Sep 28, 2023
These tests have become even more flaky with the updated CI runners; it seems that this is triggered due to using the significantly quicker docker-compose v2. Use the existing await-connectivity script to determine when a test can safely start to run, instead of sleeping for arbitrary number of seconds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests have become even more flaky with the updated CI runners; it seems that this is triggered due to using the significantly quicker docker-compose v2.
Use the existing await-connectivity script to determine when a test can safely start to run, instead of sleeping for arbitrary number of seconds.
Closes #4301
This change is