Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processmetrics: explicit type conversion to support arm64 #4446

Merged
merged 1 commit into from
Nov 24, 2023
Merged

processmetrics: explicit type conversion to support arm64 #4446

merged 1 commit into from
Nov 24, 2023

Conversation

mlegner
Copy link
Contributor

@mlegner mlegner commented Nov 24, 2023 •
edited by matzf
Loading

When building SCION in a VM on my MacBook, I got an error about mismatched types:

pkg/private/processmetrics/processmetrics_linux.go:127:17: invalid operation: newCount != c.lastTaskCount (mismatched types uint32 and uint64)
pkg/private/processmetrics/processmetrics_linux.go:133:21: cannot use newCount (variable of type uint32) as uint64 value in assignment

This modification doesn't change the behavior on amd64 but makes SCION compile also for arm64.

This change is Reviewable

@mlegner mlegner mentioned this pull request Nov 24, 2023
Merged
oncilla
oncilla approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mlegner)

@mlegner mlegner force-pushed the fix/processmetrics-type branch from 2d0ae21 to 8259079 Compare November 24, 2023 10:54
@mlegner mlegner force-pushed the fix/processmetrics-type branch from 8259079 to a6810bb Compare November 24, 2023 10:54
@mlegner
Copy link
Contributor Author

mlegner commented Nov 24, 2023

Just added a //nolint comment to placate the linter.

mlegner
mlegner commented Nov 24, 2023
View reviewed changes
Copy link
Contributor Author

@mlegner mlegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mlegner)

oncilla
oncilla approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @mlegner)

@oncilla oncilla merged commit 799ed12 into scionproto:master Nov 24, 2023
4 checks passed
@mlegner mlegner deleted the fix/processmetrics-type branch November 27, 2023 17:54
juagargi pushed a commit to netsec-ethz/scion that referenced this pull request Mar 8, 2024
@mlegner @juagargi
processmetrics: explicit type conversion to support arm64 (scionproto…
7d95e80 
…#4446)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oncilla oncilla oncilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlegner @oncilla