Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: clarify tutorial description #4500

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

tzaeschke
Copy link
Contributor

@tzaeschke tzaeschke commented Apr 5, 2024

We had another situation where users were confused about the difference of endhost vs AS. It seems that it was caused by this tutorial which could be clarified regarding it's intention and that the acronym AS used in SCION really refers to "Autonomous System" as used in inter-domain networking..

We had another situation where users were confused about the difference of endhost vs AS. It seems that this tutorial could be clarified regarding it's intention.
@matzf
Copy link
Contributor

matzf commented Apr 5, 2024

This change is Reviewable

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tzaeschke)


doc/tutorials/deploy.rst line 4 at r1 (raw file):

====================================

This document helps you set up a freestsnding SCION demo network, which consists of a stand-alone complete SCION environment distributed among five computers. The demo environment contains one SCION Isolation Domain (:term:`ISD`), with three core Autonomous Systems (:term:`AS`) and two non-core, leaf ASes.

...set up a freestanding...

Copy link
Contributor Author

@tzaeschke tzaeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @jiceatscion)


doc/tutorials/deploy.rst line 4 at r1 (raw file):

Previously, jiceatscion wrote…

...set up a freestanding...

Done.

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)

Copy link
Contributor

@jiceatscion jiceatscion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)

Copy link
Contributor

@matzf matzf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)

@matzf matzf changed the title Clarify tutorial description doc: clarify tutorial description Apr 8, 2024
@matzf matzf merged commit 594cc03 into scionproto:master Apr 8, 2024
4 checks passed
@tzaeschke tzaeschke deleted the patch-1 branch April 8, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants