-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: update various go dependencies #4522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, 16 of 16 files at r2, 1 of 2 files at r3.
Reviewable status: 23 of 24 files reviewed, 3 unresolved discussions (waiting on @oncilla)
go.mod
line 77 at r2 (raw file):
github.com/google/uuid v1.6.0 // indirect github.com/gopherjs/gopherjs v1.17.2 // indirect github.com/hashicorp/golang-lru/arc/v2 v2.0.7
Move this back up into first require
block? (I'm confused why go tidy doesn't complain).
licenses/data/com_github_getkin_kin_openapi/openapi3/license.go
line 1 at r2 (raw file):
package openapi3
Update the tools/licenses.sh to remove this stray match.
licenses/data/org_modernc_libc/testdata/nsz.repo.hu/libc-test/src/math/crlibm/COPYING
line 1 at r2 (raw file):
GNU GENERAL PUBLIC LICENSE
It might make sense to exclude this from the files; this is test framework used by modernc.org/libc, but we do not use it or compile it into our binaries or anything like that. Thus, the license terms do not apply to us. Just to make sure that there is no misunderstanding, it might be prudent to explicitly ignore this file for the licenses collection.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 18 of 25 files reviewed, 3 unresolved discussions (waiting on @matzf)
go.mod
line 77 at r2 (raw file):
Previously, matzf (Matthias Frei) wrote…
Move this back up into first
require
block? (I'm confused why go tidy doesn't complain).
Not sure how it got here, I did not manually add it 🤷
licenses/data/com_github_getkin_kin_openapi/openapi3/license.go
line 1 at r2 (raw file):
Previously, matzf (Matthias Frei) wrote…
Update the tools/licenses.sh to remove this stray match.
Done. Hopefully this is a bit more robust than the individual file block list that we have
licenses/data/org_modernc_libc/testdata/nsz.repo.hu/libc-test/src/math/crlibm/COPYING
line 1 at r2 (raw file):
Previously, matzf (Matthias Frei) wrote…
It might make sense to exclude this from the files; this is test framework used by modernc.org/libc, but we do not use it or compile it into our binaries or anything like that. Thus, the license terms do not apply to us. Just to make sure that there is no misunderstanding, it might be prudent to explicitly ignore this file for the licenses collection.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 6 of 6 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @oncilla)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @oncilla)
No description provided.