tools: topogen: Fix network argument. Added IPv6 network argument. #4536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… default network defines from net.py to defines.py for consistency
|
This change is |
oncilla
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @GioBar00 and @matzf)
a discussion (no related file):
Thank you for your contribution.
oncilla
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @matzf)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The argument
-nor--networkin topogen.py is ignored when generating a topology, the default network is always used.There exists no argument for the user to specify a different IPv6 network with respect to the default one.
I have added the argument
-n6or--network-v6which is the IPv6 version of the--networkargument.I moved for consistency the variables like
DEFAULT_NETWORKfrom net.py to defines.py where the IPv6 network defines are already present.