Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: support 16bit interface IDs in topo files #4636

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

tzaeschke
Copy link
Contributor

Change the limit for interface IDs in topofiles from 12bit to 16bit.

Change the limit for interface IDs in topofiles from 12bit to 16bit.
@jiceatscion
Copy link
Contributor

This change is Reviewable

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)

@tzaeschke
Copy link
Contributor Author

@jiceatscion @FR4NK-W
I am still unsure about this "reviewable" application.
Why does it say "waiting on @tzaeschke"?
I probably shouldn't mark it as "reviewed¨ myself....?

Copy link
Contributor

@FR4NK-W FR4NK-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @tzaeschke)

@jiceatscion jiceatscion merged commit 7956be9 into scionproto:master Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants