Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: offsets are unambiguous if they have axis attr #50

Merged
merged 2 commits into from
Jan 21, 2025
Merged

feat: offsets are unambiguous if they have axis attr #50

merged 2 commits into from
Jan 21, 2025

Conversation

jokasimr
Copy link
Contributor

Fixes #49

SimonHeybrock
SimonHeybrock approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@SimonHeybrock SimonHeybrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jokasimr
Copy link
Contributor Author

jokasimr commented Jan 20, 2025 •
edited
Loading

chexus still fails on the latest NMX files from coda though, is that expected?

(I've asked ECDC about this.)

@jokasimr jokasimr merged commit 1a524ae into main Jan 21, 2025
4 checks passed
@jokasimr jokasimr deleted the nxdetector-offsets-axis branch January 21, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonHeybrock SimonHeybrock SimonHeybrock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Development Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NMX integration test failing: Shape of pixel offsets does not correspond to detector_number
2 participants
@jokasimr @SimonHeybrock