fix: separate series subgraphs by index name #112
Conversation
Yes, all must be the same. |
src/sciline/visualize.py
Outdated
| return name.split('[')[0] | ||
| sgname = name.split('[')[0] | ||
| if sgname == 'Series': | ||
| return name.partition('[')[-1].partition(']')[0] |
There was a problem hiding this comment.
A comment would be useful here.
There was a problem hiding this comment.
I've added a comment but I'm not sure it's clear and accurate. Do you have a better suggestion?
There was a problem hiding this comment.
My point was: It is unclear to a superficial reader what "name.partition('[')[-1].partition(']')[0]" does, can you maybe add an example of what it is parsing/partitioning, to explain this?
There was a problem hiding this comment.
Why of there are some nested [...], does this still work?
There was a problem hiding this comment.
No it doesn't :/ (fixed now)
jokasimr
force-pushed
the
fix-series-in-same-subgraph
branch
from
bdcae87 to
3b0ad13
Compare
Fixes #104
Here's how the graph looks after the change:
I'm still a bit unsure what the correct behavior is here.
When should two
Series[ ... ]nodes be collected in a subgraph?Is it when all types inside
[ ... ]are the same?