fix: warn if missing vector in transformation #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/scippnexus/base.py
Outdated
| try: | ||
| dg = maybe_transformation(self, value=dg, sel=sel) | ||
| except (sc.DimensionError, NexusStructureError) as e: | ||
| self._warn_fallback(e) |
There was a problem hiding this comment.
I think this is actually the wrong warning, since it will say "failed to load as NXlog", but that part worked. The subsequent parsing of the log as a transform failed. Maybe moving the try/catch into maybe_transformation is better after all?
There was a problem hiding this comment.
Moved the test into maybe_transformation instead, and made it emit the warning if the transform loading errored out for any reason. Is that desirable?
src/scippnexus/nxtransformations.py
Outdated
Comment on lines
90
to
91
| if self.attrs.get('vector') is None: | ||
| raise NexusStructureError('A transformation needs a vector attribute') |
There was a problem hiding this comment.
Yes, I think using this error is ok.
There was a problem hiding this comment.
How about using TransformationError?
src/scippnexus/nxtransformations.py
Outdated
Comment on lines
90
to
91
| if self.attrs.get('vector') is None: | ||
| raise TransformationError('A transformation needs a vector attribute.') |
There was a problem hiding this comment.
Better put this into self.vector?
jokasimr
force-pushed
the
nxtransformation-warn
branch
from
71dc6c8
to
0b7667d
Compare
SimonHeybrock
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes scipp/essreflectometry#81
NexusStructureErrorthe right kind of error to raise if the transform is missing thevectorattribute?