Fixes for scipp-0.14 #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jl-wynen
reviewed
Jun 1, 2022
| assert detector[...].shape == [4] | ||
| assert detector[()].shape == [4] | ||
| assert tuple(detector[...].shape) == (4, ) | ||
| assert tuple(detector[()].shape) == (4, ) |
There was a problem hiding this comment.
Looks odd. Why does this convert the LHS to a tuple and then test with a tuple on the RHS? Looks like the LHS should have already been a tuple to warrant a change.
There was a problem hiding this comment.
Because we are running tests against both the latest (current frozen) scipp as well as an old version of scipp (which still gives a list).
jl-wynen
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will make a patch release when merged.