Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of scipy.fftpack with scipy.fft #716

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Replace use of scipy.fftpack with scipy.fft #716

merged 2 commits into from
Feb 22, 2024

Conversation

mdhaber
Copy link
Contributor

@mdhaber mdhaber commented Feb 20, 2024

scipy.fftpack is considered legacy; this updates uses of scipy.fftpack to use scipy.fft, instead. To avoid unnecessary churn, I didn't modify filenames that include fftpack.

rossbar
rossbar approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@rossbar rossbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mdhaber! +1 for updating the references away from fftpack + the other fixups here

intro/scipy/examples/solutions/plot_image_blur.py Outdated Show resolved Hide resolved
@mdhaber @rossbar
Apply suggestions from code review
cd8bbdd 
Co-authored-by: Ross Barnowski <rossbar@berkeley.edu>
@jarrodmillman jarrodmillman merged commit 7a6633e into scipy-lectures:main Feb 22, 2024
9 checks passed
@jarrodmillman jarrodmillman added this to the 2024.1 release milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossbar rossbar rossbar approved these changes

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
2024.1 release
Development

Successfully merging this pull request may close these issues.
3 participants
@mdhaber @jarrodmillman @rossbar