This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 7
CI/CD for container image #25
Merged
OR13
merged 3 commits into
scitt-community:main
from
johnandersen777:ci_cd_container_image
Aug 24, 2023
Merged
CI/CD for container image #25
OR13
merged 3 commits into
scitt-community:main
from
johnandersen777:ci_cd_container_image
Aug 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnandersen777
commented
Mar 30, 2023
•
edited
Loading
edited
- Add Dockerfile
- Add container build to CI
- References
- https://docs.github.com/en/actions/publishing-packages/publishing-docker-images#publishing-images-to-github-packages
- https://hub.docker.com/_/python/
- Future
- Enclave (non-virtual CCF) capable containers https://gramine.readthedocs.io/projects/gsc/en/latest/
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
2344ad3
to
d9539f0
Compare
johnandersen777
pushed a commit
to intel/dffml
that referenced
this pull request
Mar 30, 2023
…ocker-compose: Add scitt API emulator Related: scitt-community/scitt-api-emulator#25 Related: ietf-scitt/use-cases#14 Related: https://codeberg.org/forgejo/discussions/issues/12 Related: ietf-scitt/use-cases#18 Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
dcd3d8d
to
4670828
Compare
OR13
previously approved these changes
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
4670828
to
0a24227
Compare
johnandersen777
commented
Mar 31, 2023
.github/workflows/ci.yml
Outdated
ci-cd-build-and-push-image-container: | ||
name: CI/CD (container) | ||
runs-on: ubuntu-latest | ||
if: ${{ github.ref == 'refs/heads/main' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Force pushed due to originally missing final }
on this line
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
0a24227
to
b475561
Compare
johnandersen777
commented
Mar 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Realized we should probably build the container on pull requests after seeing and fixing the missing trailing }
on the ${{ github.ref == 'refs/heads/main' }}
check. This now skips push unless on main branch.
johnandersen777
commented
Apr 3, 2023
Signed-off-by: John Andersen <johnandersenpdx@gmail.com>
OR13
approved these changes
Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.