Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python 2 and the rest of EL 7 #696

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Remove Python 2 and the rest of EL 7 #696

merged 2 commits into from
Jul 17, 2024

Conversation

frenzymadness
Copy link
Member

No description provided.

@frenzymadness
Copy link
Member Author

[test-all]

@frenzymadness
Copy link
Member Author

@phracek

/usr/bin/python3: No module named pytest
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
Test for image ubi9/python-311:1 FAILED in these versions  3.11.
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
make: *** [common/common.mk:116: test-openshift-pytest] Error 1

My guess: If you want to use Python 3.12 and python3.12-pytest, you have to call python3.12 explicitly, not just python3.

@frenzymadness
Copy link
Member Author

Ping @hrnciar and @phracek

@hrnciar
Copy link
Member

hrnciar commented Jul 15, 2024

I eyeballed the changes, they are mostly removals. LGTM

@frenzymadness
Copy link
Member Author

@phracek could you please confirm that the failures in the CI are expected now?

@phracek
Copy link
Member

phracek commented Jul 17, 2024

Well the problem with pytest was fixed by PR #694.

@phracek
Copy link
Member

phracek commented Jul 17, 2024

[test]

phracek
phracek approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@phracek phracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for this issue.

@frenzymadness frenzymadness merged commit d463c14 into master Jul 17, 2024
23 of 28 checks passed
@frenzymadness frenzymadness deleted the rmPy2 branch July 17, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phracek phracek phracek approved these changes

@hrnciar hrnciar hrnciar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frenzymadness @hrnciar @phracek