-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build and push image to quay.io/fedora/ruby-33 repository #548
Conversation
Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
[test-all] |
@jackorp PTAL. Let's build and push Fedora ruby-containers into quay.io/fedora/ruby-{version} registries. |
My eyes don't see anything else that would seem out of place or weird, so rest is LGTM. |
What about the test suite failures? |
|
Fedora Ruby 3.3 is failing on compiling the gems for some time now. It might be that an update of some app's gems are needed due to some changes or updates in compiler on Fedora. I haven't had time to properly investigate it yet. |
There was a bit outage of OpenShift cluster. re-running tests and let's see. |
Ruby-3.3 tests on Fedora are reported here: #550 |
@phracek sclorg/rails-ex#173 to fix the Fedora Ruby 3.3 was merged, please re-run the tests. |
[test] |
Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using? Also the question is how come the test passes when the build of the container for test seems to fail? |
I will look at it. It seems like it is not related to OpenShift 4. |
Sounds good to me. |
@jackorp I checked the logs for Fedora 3.3 and rails-ex is not used. It is used only in test case 'test_from_dockerfile'. I guess, the failure should be caused by different an issue. The test case that failed is 'test_npm_functionality' |
I have created #554 |
I guess, this can be merged, right? |
Yes, I'd say we can go ahead with this. |
This pull request adds GitHub action for building and pushing each Fedora ruby container
into quay.io/fedora/ruby-{version} registry