Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build and push image to quay.io/fedora/ruby-33 repository #548

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

phracek
Copy link
Member

@phracek phracek commented Jun 19, 2024

This pull request adds GitHub action for building and pushing each Fedora ruby container
into quay.io/fedora/ruby-{version} registry

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Jun 19, 2024

[test-all]

@phracek
Copy link
Member Author

phracek commented Jun 19, 2024

@jackorp PTAL. Let's build and push Fedora ruby-containers into quay.io/fedora/ruby-{version} registries.

@jackorp
Copy link
Contributor

jackorp commented Jun 19, 2024

My eyes don't see anything else that would seem out of place or weird, so rest is LGTM.

@pvalena
Copy link
Member

pvalena commented Jun 19, 2024

What about the test suite failures?

@pvalena
Copy link
Member

pvalena commented Jun 19, 2024

Installing sass-rails 6.0.0
Gem::Ext::BuildError: ERROR: Failed to build gem native extension.

current directory:
/opt/app-root/src/bundle/ruby/3.3.0/gems/sqlite3-1.4.4/ext/sqlite3

@jackorp
Copy link
Contributor

jackorp commented Jun 19, 2024

What about the test suite failures?

Fedora Ruby 3.3 is failing on compiling the gems for some time now. It might be that an update of some app's gems are needed due to some changes or updates in compiler on Fedora.

I haven't had time to properly investigate it yet.

@phracek
Copy link
Member Author

phracek commented Jun 20, 2024

There was a bit outage of OpenShift cluster. re-running tests and let's see.

@phracek
Copy link
Member Author

phracek commented Jun 25, 2024

Ruby-3.3 tests on Fedora are reported here: #550

@jackorp
Copy link
Contributor

jackorp commented Jul 10, 2024

@phracek sclorg/rails-ex#173 to fix the Fedora Ruby 3.3 was merged, please re-run the tests.

@phracek
Copy link
Member Author

phracek commented Jul 17, 2024

[test]

@jackorp
Copy link
Contributor

jackorp commented Jul 17, 2024

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

@phracek
Copy link
Member Author

phracek commented Jul 17, 2024

Looks like Fedora Ruby 3.3 passed, but there is still failing gem build (Search for line An error occurred while installing nio4r (2.5.7), and Bundler cannot continue., which is at the end of failed installation), but it doesn't lead to failed CI or a failed test, so I am quite confused what source is being used there (it is not the rails-ex app).

JFTR, it seems like the same class of issue as sqlite3 so some app probably needs dependency adjustment, I just am not sure which one. Could we add a log line into tests that would say what is URL (with branch ideally) of a cloned app or if it is some "app" local to this repo, which source it is actually using?

Also the question is how come the test passes when the build of the container for test seems to fail?

I will look at it. It seems like it is not related to OpenShift 4.
I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

@jackorp
Copy link
Contributor

jackorp commented Jul 17, 2024

I prefer to file an issue with the error and fix it later on, so we do not block this issue. WDYT?

Sounds good to me.

@phracek
Copy link
Member Author

phracek commented Jul 17, 2024

@jackorp I checked the logs for Fedora 3.3 and rails-ex is not used. It is used only in test case 'test_from_dockerfile'. I guess, the failure should be caused by different an issue. The test case that failed is 'test_npm_functionality'

@jackorp
Copy link
Contributor

jackorp commented Jul 17, 2024

I prefer to file an issue with the error and fix it later on,

I have created #554

@phracek
Copy link
Member Author

phracek commented Jul 17, 2024

I guess, this can be merged, right?

@jackorp
Copy link
Contributor

jackorp commented Jul 17, 2024

Yes, I'd say we can go ahead with this.

@phracek phracek merged commit 2470c5e into master Jul 17, 2024
16 checks passed
@phracek phracek deleted the add_build_and_push_for_fedora branch July 17, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants