-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply ignore settings when copying file #745
Conversation
Could you help us with the end user testing @mmindenhall please ? You can follow those steps to install the plugin from this PR locally |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #745 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 35
Lines ? 997
Branches ? 100
========================================
Hits ? 997
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Code Climate has analyzed commit 526cc30 and detected 0 issues on this pull request. View more on Code Climate. |
Hi @scolladon, Apologies for the delayed reply...I was on vacation all of last week. I just did the following to verify your fix:
Thanks! |
Thanks for your contribution on validating the fix @mmindenhall |
Shipped in release $ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.32.0 Happy incremental deployment! |
Explain your changes
Ensure ignore service is called when copying files
Does this close any currently open issues?
closes #744