Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue copying resource, meta and folder for resource type #896

Merged
merged 3 commits into from
Aug 2, 2024

Conversation

scolladon
Copy link
Owner

Explain your changes


Ensure we copy every files for resource

  • The resource files
  • The metadata file

Let the fsHelper layer handle duplicate call to copyFiles

Does this close any currently open issues?


closes #895

  • Jest tests added to cover the fix.
  • NUT tests added to cover the fix.
  • E2E tests added to cover the fix.

@scolladon
Copy link
Owner Author

Hi @RohitGagan16 !

Could you test on your side and help us validate the fix please ?
You can follow those steps to easily do it on your side

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0f186ce) to head (6214b09).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #896   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines         1074      1078    +4     
  Branches       115       114    -1     
=========================================
+ Hits          1074      1078    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mehdicherf
mehdicherf previously approved these changes Jul 31, 2024
Copy link

codeclimate bot commented Jul 31, 2024

Code Climate has analyzed commit 6214b09 and detected 0 issues on this pull request.

View more on Code Climate.

@scolladon scolladon merged commit 10fd87a into main Aug 2, 2024
19 of 22 checks passed
@scolladon scolladon deleted the fix/resource-files-copy branch August 2, 2024 11:55
Copy link

github-actions bot commented Aug 2, 2024

Shipped in release v5.41.0.
You can install the new version using the version number or the latest-rc channel

$ sfdx plugins:install sfdx-git-delta@latest-rc
$ sfdx plugins:install sfdx-git-delta@v5.41.0

Happy incremental deployment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource file changed does not copy the whole static resource
2 participants