protoc: complete all --*_out without more specific handling with dirs

scop · Mar 29, 2020 · a10adf2 · a10adf2
1 parent 9caf5c9
commit a10adf2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/completions/protoc b/completions/protoc
@@ -6,10 +6,6 @@ _protoc()
     _init_completion -s || return
 
     case $prev in
-        --proto_path|--cpp_out|--java_out|--python_out)
-            _filedir -d
-            return
-            ;;
         --version|-h|--help|--encode|--decode)
             return
             ;;
@@ -28,6 +24,10 @@ _protoc()
             fi
             return
             ;;
+        --proto_path|--*_out)
+            _filedir -d
+            return
+            ;;
     esac
 
     $split && return

diff --git a/test/t/test_protoc.py b/test/t/test_protoc.py
@@ -9,3 +9,12 @@ def test_1(self, completion):
     @pytest.mark.complete("protoc -", require_cmd=True)
     def test_2(self, completion):
         assert completion
+        assert any(
+            x.endswith("_out") or x.endswith("_out=") for x in completion
+        )
+
+    @pytest.mark.complete(
+        "protoc --non_existent_plugin_out ", cwd="shared/default"
+    )
+    def test_all_out(self, completion):
+        assert completion == ["bar bar.d/", "foo.d/"]