test: replace some echos with printfs

scop · May 11, 2020 · bcdf00c · bcdf00c
1 parent febf177
commit bcdf00c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/t/conftest.py b/test/t/conftest.py
@@ -115,8 +115,8 @@ def _avahi_hosts(bash: pexpect.spawn) -> List[str]:
 def known_hosts(bash: pexpect.spawn) -> List[str]:
     output = assert_bash_exec(
         bash,
-        # TODO: why does printf instead of echo hang here?
-        '_known_hosts_real ""; echo "${COMPREPLY[@]}"; unset COMPREPLY',
+        '_known_hosts_real ""; '
+        r'printf "%s\n" "${COMPREPLY[@]}"; unset COMPREPLY',
         want_output=True,
     )
     return sorted(set(output.split()))

diff --git a/test/t/unit/test_unit_known_hosts_real.py b/test/t/unit/test_unit_known_hosts_real.py
@@ -49,8 +49,8 @@ def test_basic(
         output = assert_bash_exec(
             bash,
             "_known_hosts_real -a%sF _known_hosts_real/config '%s'; "
-            # TODO: why does printf instead of echo hang here?
-            'echo "${COMPREPLY[@]}"; unset COMPREPLY' % (colon_flag, prefix),
+            r'printf "%%s\n" "${COMPREPLY[@]}"; unset COMPREPLY'
+            % (colon_flag, prefix),
             want_output=True,
         )
         assert sorted(output.split()) == sorted(expected)