vncviewer: Cleanup shopt use, drop an eval

scop · Apr 23, 2016 · cfc6212 · cfc6212
1 parent 47c5c97
commit cfc6212
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/completions/vncviewer b/completions/vncviewer
@@ -87,12 +87,11 @@ _xvnc4viewer()
             WMDecorationWidth ZlibLevel )
         [[ "$cur" == --* ]] && dash=-- || dash=-
 
-        local option oldNoCaseMatch=$(shopt -p nocasematch)
-        shopt -s nocasematch
+        local option reset=$( shopt -p nocasematch ); shopt -s nocasematch
         COMPREPLY=( $( for option in "${options[@]}"; do
                 [[ $dash$option == "$cur"* ]] && printf '%s\n' $dash$option
             done ) )
-        eval "$oldNoCaseMatch" 2>/dev/null
+        $reset
     else
         _known_hosts_real "$cur"
     fi