cvs, modprobe, sh: address shellcheck SC2209

scop · Apr 11, 2020 · f894bc1 · f894bc1
1 parent a5890aa
commit f894bc1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/completions/cvs b/completions/cvs
@@ -74,7 +74,7 @@ _cvs()
                     mode=add
                     ;;
                 admin|adm|rcs)
-                    mode=admin
+                    mode="admin"
                     ;;
                 annotate|ann|blame|rannotate|rann|ra)
                     mode=annotate
@@ -86,10 +86,10 @@ _cvs()
                     mode=commit
                     ;;
                 diff|di|dif)
-                    mode=diff
+                    mode="diff"
                     ;;
                 export|ex|exp)
-                    mode=export
+                    mode="export"
                     ;;
                 edit|unedit|editors|logout|pserver|server|watch|watchers)
                     mode=$i

diff --git a/completions/modprobe b/completions/modprobe
@@ -50,7 +50,7 @@ _modprobe()
                 mode=list
                 ;;
             --dump-modversions)
-                mode=file
+                mode="file"
                 ;;
             --set-version|-!(-*)S)
                 version=${words[i+1]} # -S is not $prev and not $cur

diff --git a/completions/sh b/completions/sh
@@ -28,7 +28,7 @@ _sh()
 
     local args ext=
     _count_args "" "@(-c|[-+]o)"
-    [[ $args -eq 1 ]] && ext=sh
+    [[ $args -eq 1 ]] && ext="sh"
     _filedir $ext
 } &&
 complete -F _sh sh