test: make the pytest option testcase require cmd #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
approved these changes
Feb 6, 2024
It fails if the command doesn't exist, since the options are parsed from the command invocation.
yedayak
force-pushed
the
pytest-requires-cmd
branch
from
319deec
to
10c3588
Compare
akinomyoga
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
mypy in the CI complains as
mypy.....................................................................Failed
- hook id: mypy
- exit code: 2
venv/lib/python3.12/site-packages/_pytest/_code/code.py:401: error: Positional-only parameters are only supported in Python 3.8 and greater [syntax]
Found 1 error in 1 file (errors prevented further checking)
venv/lib/python3.12/site-packages/_pytest/_code/code.py:401: error: Positional-only parameters are only supported in Python 3.8 and greater [syntax]
Found 1 error in 1 file (errors prevented further checking)
venv/lib/python3.12/site-packages/_pytest/_code/code.py:401: error: Positional-only parameters are only supported in Python 3.8 and greater [syntax]
Found 1 error in 1 file (errors prevented further checking)
venv/lib/python3.12/site-packages/_pytest/_code/code.py:401: error: Positional-only parameters are only supported in Python 3.8 and greater [syntax]
Found 1 error in 1 file (errors prevented further checking)
Maybe this is an issue of a specific version of mypy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fails if the command doesn't exist, since the options are parsed from the command invocation.