Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(make): fix stripped directory names with bind 'set show-all-if-ambiguous on' #546

Merged
merged 4 commits into from
Jan 23, 2023
Merged

fix(make): fix stripped directory names with bind 'set show-all-if-ambiguous on' #546

merged 4 commits into from
Jan 23, 2023

Commits on Jan 10, 2023

  1. test(make): add test cases for GitHub scop#544

    @akinomyoga
    akinomyoga committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    64630aa View commit details
    Browse the repository at this point in the history

  2. fix(make): do not strip dirnames for COMP_TYPE=37 (%) and 42 (*)

    @akinomyoga
    akinomyoga committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    a1a94f6 View commit details
    Browse the repository at this point in the history

  3. fix(make): show unique targets in subdirs 

    When many targets in subdirectories are defined in Makefile, we
typically want to list the files or subdirectories in the current
directory.  However, when the file in the subdirectory is unique, we
may generate the full path.  See also the discussion on GitHub:

scop#544
scop#546 (comment)
    @akinomyoga
    akinomyoga committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    1ea3326 View commit details
    Browse the repository at this point in the history

  4. fix(make): deactivate the display-only mode 

    In the display-only mode where COMP_TYPE=9, 37, or 42, only a part of
the completion is stored in COMPREPLY for displaying purposes.  For
example, "xyz" is stored in COMPREPLY when "abc/xyz" is the candidate
and "abc/" is already inserted.

However, the test framework extracts generated completions using
COMP_TYPE=37 by setting "set show-all-if-ambiguous off", which would
be broken by the display-only mode.  There is no simple way to make it
work with the test framework, and the display-only mode does not seem
to be essential.  For the time being, we deactivate the display-only
mode.  See also discussions in the following links:

scop#544
scop#546
    @akinomyoga
    akinomyoga committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    5eb1042 View commit details
    Browse the repository at this point in the history