fix(_known_hosts_real): exclude directories from the config files

[akinomyoga]

Fixes #817

[scop]

Let's add some dirs to the mix in the test suite.

[akinomyoga]

Let's add some dirs to the mix in the test suite.

Thanks! I have added an Include directive in config_include for the test of ssh_config inclusions (454bbe3).

However, directories at e.g. ~/.ssh/config and Include <directory> seem to be just misconfigurations. I have checked the man page man ssh_config, but Include directive does not seem to accept a directory name. I have tried it in my actual ssh configuration, but Include <directory> seems to be just ignored. In this sense, maybe we shouldn't fix it but leave the error messages, or we can output a more friendly message that explains the issue. But then, a question is why we have been ignoring unreadable files by testing [[ -r $file ]]. If we take the Include directive as "include-if-exists", we can consider a case an unrelated directory is created at the same path, which should be ignored.

[scop]

Parts of the discussion about error messages at #807 (comment) applies here too. Silently suppressing isn't nice, but neither is making a mess on the console, producing errors that make no sense to users, or coding and maintaining precise assumptions about undocumented details of external tool behavior into bash-completion. Whether silently suppressing is the best option or not, at least we are quite consistent with it currently. I'm open to discussing the general approach, but that's probably better done elsewhere.

[akinomyoga]

Thanks!

Parts of the discussion about error messages at #807 (comment) applies here too.

I also remember the discussion at #776 (comment).

Whether silently suppressing is the best option or not, at least we are quite consistent with it currently. I'm open to discussing the general approach, but that's probably better done elsewhere.

OK! Thank you!