Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new stages names to silence pre-commit warning #31

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

JulienGrv
Copy link
Contributor

This fixes following warning:

[INFO] Initializing environment for https://github.com/scop/pre-commit-shfmt.
[WARNING] repo `https://github.com/scop/pre-commit-shfmt` uses deprecated stage names (commit, merge-commit, push) which will be removed in a future version.  Hint: often `pre-commit autoupdate --repo https://github.com/scop/pre-commit-shfmt` will fix this.  if it does not -- consider reporting an issue to that repo.
[INFO] Installing environment for https://github.com/scop/pre-commit-shfmt.

@JulienGrv JulienGrv force-pushed the feature/use-new-stages-names branch from 40b5072 to ed34aca Compare October 9, 2024 10:05
@scop
Copy link
Owner

scop commented Oct 14, 2024

I believe (but have not verified) that doing this would mean that the hooks would no longer work with pre-commit < 4. If so, I'm inclined to not make this change yet.

@JulienGrv
Copy link
Contributor Author

Hi @scop , AFAIK the warnings were introduced with version 4.0 but the new names are there since version 3.2. Anyway, I don't mind leaving this PR opened until you think the time is right

@scop
Copy link
Owner

scop commented Oct 22, 2024

Thanks for the info, looks like the "new" names are available since 3.2.0 indeed, which I think is old enough for this change.

.pre-commit-hooks.yaml Show resolved Hide resolved
@JulienGrv JulienGrv requested a review from scop October 22, 2024 22:37
Copy link
Owner

@scop scop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@scop scop merged commit 080a7bf into scop:main Nov 13, 2024
2 checks passed
@JulienGrv JulienGrv deleted the feature/use-new-stages-names branch November 14, 2024 07:10
@lucasfijen
Copy link

lucasfijen commented Nov 25, 2024

Hey! Nice to see you already merged a fix for the deprecation warnings.
Is there any chance on a new release for this hook so we can get rid of these warnings?:)

@scop
Copy link
Owner

scop commented Dec 1, 2024

v3.10.0-2 tagged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants