Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to add a test for IAM roles.
Unfortunately when adding a complete response for
list_roles
operation I stumbled across an error.If
"AssumeRolePolicyDocument"
is included in the response botocore callsjson_decode_policies
which results in the following error:It looks to me like the
AssumeRolePolicyDocument
should be a string and not a dict.However when making a boto call to
list_roles
AssumeRolePolicyDocument
is a python dict, so I think my json response is valid?Can I safely ignore this issue and change
AssumeRolePolicyDocument
to an escaped string containing the dict ?