Updated docs based on latest Score release #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishumanitec
requested changes
Oct 9, 2023
| @@ -244,6 +246,8 @@ readinessProbe: | |||
| - `target`: specifies a path and name. | |||
| - `mode`: specifies access mode. | |||
| - `content`: specifies inline content and supports templates. | |||
There was a problem hiding this comment.
Exactly one of content or source must be specified.
Suggest:
content: specifies inline content and supports templates. Exactly one ofcontentorsourcemust be defined.
| @@ -244,6 +246,8 @@ readinessProbe: | |||
| - `target`: specifies a path and name. | |||
| - `mode`: specifies access mode. | |||
| - `content`: specifies inline content and supports templates. | |||
| - `source`: specifies a path to a file to make available. | |||
There was a problem hiding this comment.
Exactly one of content or source must be specified.
Suggest:
source: specifies a path to a file to make available. Exactly one ofcontentorsourcemust be defined.
| @@ -244,6 +246,8 @@ readinessProbe: | |||
| - `target`: specifies a path and name. | |||
| - `mode`: specifies access mode. | |||
| - `content`: specifies inline content and supports templates. | |||
| - `source`: specifies a path to a file to make available. | |||
| - `noExpand`: If true, placeholder expansion will not occur in the `content`. | |||
There was a problem hiding this comment.
Is not super clear. Would suggest the more clear:
noExpand: If true, thecontentor file referenced insourcewill be used literally with no placeholder expansion in the running container.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated docs based on latest release v.0.8.0:
workload-source-urlto specify URL of file that is managing the humanitec workload.Not included:
--messageparameter (deployment'scommentwith--messagescore-humanitec#57) is already documented for the delta and message command