Updated docs to support resource classes in Score spec #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishumanitec
requested changes
Oct 25, 2023
| `type`: specifies the resource type. | ||
|
|
||
| - **Type**: string. | ||
| - **Constraints**: alphanumeric string. |
There was a problem hiding this comment.
alphanumeric with dashes
There was a problem hiding this comment.
Same for class below
There was a problem hiding this comment.
I assume the same is true for resource-name and annotations? https://docs.score.dev/docs/reference/score-spec-reference/#resources
| - **Type**: string. | ||
| - **Constraints**: alphanumeric string. | ||
|
|
||
| `class`: a specialisation of the resource type. For example, a workload that needs an externally accessible resource might set the class to external while the workload that requires an encrypted resource might have a class of sensitive. |
There was a problem hiding this comment.
suggest replace resource with storage bucket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for resource classes as described in score-spec/spec#65