Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): fixed the description of liveness and readiness probe in the spec #65

Conversation

astromechza
Copy link
Member

See #64 for a description of the issue and a Before screenshot.

This change amends the documentation for the container probes.

After:

image

Tested by running the Dockerfile-publish container locally and taking the screenshot above.

Have you read the Contributing Guidelines?

…n the spec

Signed-off-by: Ben Meier <ben.meier@humanitec.com>
Copy link
Contributor

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astromechza astromechza merged commit 1f4db8e into main Nov 11, 2023
1 check passed
@astromechza astromechza deleted the 64-documentation-for-container-probes-show-scheme-outside-the-httpget branch November 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation for container probes show scheme outside the httpGet
2 participants