Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): removed unknown hostIP field from docs #66

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

astromechza
Copy link
Member

See score-spec/schema#7 for the initial description of this issue.

HostIP is not a field in the score schema, and is not supported by any implementation of score at the moment.

I think we should remove this for now, if it needs to be added it should be added first to the schema.

Signed-off-by: Ben Meier <ben.meier@humanitec.com>
Copy link
Contributor

@chrishumanitec chrishumanitec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@astromechza astromechza merged commit 952fd48 into main Nov 11, 2023
1 check passed
@astromechza astromechza deleted the remove-hostip-reference-from-docs branch November 11, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants