Changed extension file example to show route and annotations #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sujaya-sys
approved these changes
Feb 1, 2024
There was a problem hiding this comment.
LGTM - I can take care of duplicating these changes in https://github.com/score-spec/score-humanitec/tree/main/examples/04-extras
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the motivation?
The current Score extension file example is outdated. The "ingress" element is deprecated and should be replaced by "route" resources in the Score file.
What does this change do?
Replaces the Score extension file example with a current combination of Score file and Score extension file. The Score file now shows the "route" resource to help advertise this change, especially for readers of the page who might seek the replacement. As a new demo element for the extension file, it now shows annotations on both container and service.
What is your testing strategy?
I processed this combination of files with the
score-humanitecCLI to ensure their correctness.Is this related to any issues?
No, except the deprecation of the "ingress" element.
Have you read the Contributing Guidelines?