fix: update embedded score specification and fix reference docs #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
requested review from
TobiasBabin and
sujaya-sys
and removed request for
TobiasBabin
johanneswuerbach
suggested changes
Feb 27, 2024
astromechza
force-pushed
the
update-spec
branch
from
69f4044
to
8ed3157
Compare
…pdate-spec 515c899 fix: make httpGet probe port required, fix volume read_only to be camelCase (#13) 2fb2c34 feat: added field restrictions and tests to the repository (#12) 1883aea fix: removed fully deprecated and unsupported resource properties field (#11) git-subtree-dir: schemas git-subtree-split: 515c89903bd1460a9b3e0ff7fb0b77d3cbd29cac Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
force-pushed
the
update-spec
branch
from
8ed3157
to
7d8c571
Compare
|
Thanks @johanneswuerbach, fixed up |
johanneswuerbach
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the score specification embedded in these docs and updates the reference docs to fix some missing details and incorrect names (primarily volume read_only).
This was done via a
subptree pullas documented in the score-spec/schema repo (which is why the makefil and sample were pulled in).🚀