Add custom alias template to fix redirects #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We appreciate you spending the time to work on these changes.
What is the motivation?
The recent page restructurings introduced page redirects to continue serving the pre-existing URLs. Those redirects, implemented as Hugo
aliasentries, do not work properly and consistently link to ahttp://localhost...address.What does this change do?
The change introduces a custom alias template as per the official documentation. It makes sure that the relative link is used at all times for redirects.
What is your testing strategy?
I inspected the
index.htmlfiles that Hugo generates for each redirect location. Where previously the redirect target was an absolute URLhttp://localhost:1313/some/page..., it is now a relative URL/some/page.Have you read the Contributing Guidelines?