Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumping go 1.22 to go 1.23 #181

Merged
merged 3 commits into from
Oct 14, 2024
Merged

Conversation

7h3-3mp7y-m4n
Copy link
Contributor

Doing the following changes to upgrade go from 1.22 to go 1.23

Description

Did the changes as mentioned at #179

What does this PR do?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@mathieu-benoit mathieu-benoit linked an issue Oct 12, 2024 that may be closed by this pull request
Signed-off-by: 7h3-3mp7y-m4n <emailtorash@gmail.com>
@mathieu-benoit
Copy link
Contributor

mathieu-benoit commented Oct 13, 2024

@7h3-3mp7y-m4n, CI/test is not running on the PR, because of this 16cab87, could you please re-sync your branch in your fork with upstream's main branch? Thanks!

Copy link
Contributor

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI/test passing successfully, LGTM, thanks for your contribution!
https://github.com/score-spec/score-compose/actions/runs/11315374656/job/31466472345?pr=181

@mathieu-benoit
Copy link
Contributor

@delca85, could you please give this a quick review in case we are missing anything here? Thanks!

Copy link

@delca85 delca85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mathieu-benoit mathieu-benoit merged commit a3c806e into score-spec:main Oct 14, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request] Bump go from 1.22 to 1.23
3 participants